Skip to content

add E2E pystein and generic binding tests for table. #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2022
Merged

add E2E pystein and generic binding tests for table. #1045

merged 1 commit into from
Jul 5, 2022

Conversation

pdthummar
Copy link
Contributor

Description

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@YunchuWang YunchuWang force-pushed the pthummar/table_E2E_tests branch from 1848faf to d7a3993 Compare June 2, 2022 21:00
YunchuWang
YunchuWang reviewed Jun 2, 2022
View reviewed changes
YunchuWang
YunchuWang reviewed Jun 2, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Jun 2, 2022 •
edited
Loading

Codecov Report

Merging #1045 (c7a5236) into dev (c7a5236) will not change coverage.
The diff coverage is n/a.

❗ Current head c7a5236 differs from pull request most recent head d82e3cb. Consider uploading reports for the commit d82e3cb to get more accurate results

@@           Coverage Diff           @@
##              dev    #1045   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files          34       34           
  Lines        1858     1858           
  Branches      299      299           
=======================================
  Hits         1561     1561           
  Misses        232      232           
  Partials       65       65
Flag Coverage Δ
unittests 84.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a5236...d82e3cb. Read the comment docs.

@YunchuWang YunchuWang force-pushed the pthummar/table_E2E_tests branch from d7a3993 to 4988be8 Compare June 13, 2022 18:10
@YunchuWang YunchuWang force-pushed the pthummar/table_E2E_tests branch from 8f6fd70 to 3d47351 Compare July 1, 2022 15:41
@YunchuWang YunchuWang force-pushed the pthummar/table_E2E_tests branch from a3a7525 to d82e3cb Compare July 3, 2022 02:35
@YunchuWang YunchuWang merged commit ef37809 into dev Jul 5, 2022
@YunchuWang YunchuWang deleted the pthummar/table_E2E_tests branch July 5, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunchuWang YunchuWang YunchuWang approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@gavin-aguiar gavin-aguiar Awaiting requested review from gavin-aguiar gavin-aguiar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdthummar @YunchuWang @gavin-aguiar